Reset volume options

[aujjwal-redhat]

While running a test case, I encountered an error regarding the reset volume options.
There are certain volume options that occur for all the volumes and not a specific volume.
For ex:
In this test there was a volume option cluster.server-quorum-ratio set to 70 percent which went successful as it was executed on all volumes but when it came to the reset part in the nd_parent_test it was getting reset volume wise.

[2021-05-18 19:20:30,024] INFO  - Running gluster vol reset redant-rep cluster.server-quorum-ratio --mode=script --xml on 10.70.43.74
[2021-05-18 19:20:30,275] DEBUG  - {'msg': {'opRet': '-1', 'opErrno': '30800', 'opErrstr': 'Not a valid option for single volume', 'cliOp': 'volReset', 'output': 'Not a valid option for single volume'}, 'Flag': True, 'node': '10.70.43.74', 'cmd': 'gluster vol reset redant-rep cluster.server-quorum-ratio --mode=script --xml', 'error_code': 0}
[2021-05-18 19:20:30,275] ERROR  - Not a valid option for single volume
[2021-05-18 19:20:30,276] ERROR  - Not a valid option for single volume
[2021-05-18 19:20:30,276] ERROR  - Traceback (most recent call last):
  File "./tests/nd_parent_test.py", line 90, in terminate
    self.redant.reset_volume_option(self.vol_name, opt,
  File "./common/ops/gluster_ops/volume_ops.py", line 631, in reset_volume_option
    ret = self.execute_abstract_op_node(cmd, node)
  File "./common/ops/abstract_ops.py", line 39, in execute_abstract_op_node
    raise Exception(ret['msg']['opErrstr'])
Exception: Not a valid option for single volume

Can't we check if it is a volume all option then it is reset on all or should we make such tests disruptive?

[aujjwal-redhat]

The complete log

[2021-05-18 19:20:28,724] DEBUG  - establish connection
[2021-05-18 19:20:28,878] INFO  - Running cat /var/lib/glusterd/options | grep global-option-version on 10.70.43.74
[2021-05-18 19:20:28,896] DEBUG  - {'msg': ['global-option-version=74\n'], 'Flag': True, 'node': '10.70.43.74', 'cmd': 'cat /var/lib/glusterd/options | grep global-option-version', 'error_code': 0}
[2021-05-18 19:20:28,897] INFO  - Running gluster volume set all cluster.server-quorum-ratio 70% --mode=script --xml on 10.70.43.74
[2021-05-18 19:20:30,024] DEBUG  - {'msg': {'opRet': '0', 'opErrno': '0', 'opErrstr': None, 'cliOp': 'volSet', 'output': 'Set volume successful'}, 'Flag': True, 'node': '10.70.43.74', 'cmd': 'gluster volume set all cluster.server-quorum-ratio 70% --mode=script --xml', 'error_code': 0}
[2021-05-18 19:20:30,024] INFO  - Running gluster vol reset redant-rep cluster.server-quorum-ratio --mode=script --xml on 10.70.43.74
[2021-05-18 19:20:30,275] DEBUG  - {'msg': {'opRet': '-1', 'opErrno': '30800', 'opErrstr': 'Not a valid option for single volume', 'cliOp': 'volReset', 'output': 'Not a valid option for single volume'}, 'Flag': True, 'node': '10.70.43.74', 'cmd': 'gluster vol reset redant-rep cluster.server-quorum-ratio --mode=script --xml', 'error_code': 0}
[2021-05-18 19:20:30,275] ERROR  - Not a valid option for single volume
[2021-05-18 19:20:30,276] ERROR  - Not a valid option for single volume
[2021-05-18 19:20:30,276] ERROR  - Traceback (most recent call last):
  File "./tests/nd_parent_test.py", line 90, in terminate
    self.redant.reset_volume_option(self.vol_name, opt,
  File "./common/ops/gluster_ops/volume_ops.py", line 631, in reset_volume_option
    ret = self.execute_abstract_op_node(cmd, node)
  File "./common/ops/abstract_ops.py", line 39, in execute_abstract_op_node
    raise Exception(ret['msg']['opErrstr'])
Exception: Not a valid option for single volume

[2021-05-18 19:20:30,276] DEBUG  - Deconstructing connection.

[aujjwal-redhat]

Ack

[schaffung]

But seeing the test case it should be disruptive, hence d_parent_test should be coming into picture. Also in case of volume options which can be set in volumes for non-disruptive test cases, I think this issue won't come. We might see this only in case of disruptive test cases.

[aujjwal-redhat]

Actually, I tested the test case on non-disruptive scenario. For disruptive scenario it worked totally fine as here

[schaffung]

Whenever we are setting options for all volumes i.e. a cluster level option set, that is disruptive. Let's treat it that way.

[aujjwal-redhat]

Ack