Assets/clothes duplicating if I check it with mixed tri and quad side faces.

[DanielGitFlor]

If the clothes/asset that I'am creating has mix quad and tri sides faces and I check it show a ugly error, but it make a mesh, duplicate it
Basically, if I'm doing a pants, but it has quad faces and tri faces, I try to check it it indeed show a error, ok, but it create a mesh over the pants, so evertime I check it with quad/tri it create a new mesh over the pants.

Platform and versions

• windows 10
• Blender 5.1
• MPFB 2.0.13

[joepal1976]

Thanks. Yes, I can confirm the error.

[joepal1976]

For reference, this is the stack trace:

Traceback (most recent call last):
  File "/home/joepal/source/blender-extensions/repo/mpfb/ui/makeclothes/operators/checkclothes.py", line 56, in execute
    CLOTHES_CHECKS[uuid_value] = ClothesService.mesh_is_valid_as_clothes(clothes, basemesh)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/joepal/source/blender-extensions/repo/mpfb/services/clothesservice.py", line 664, in mesh_is_valid_as_clothes
    xref = MeshCrossRef(mesh_object)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/joepal/source/blender-extensions/repo/mpfb/entities/meshcrossref.py", line 71, in __init__
    self.vertices_by_face = MeshService.get_faces_as_numpy_array(self._mesh_object)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/joepal/source/blender-extensions/repo/mpfb/services/meshservice.py", line 403, in get_faces_as_numpy_array
    raise ValueError("Faces must have the same number of vertices. Found both {} and {}".format(len(face.vertices), verts_per_face))

Obviously the "check" button shouldn't crash. It should report the problem.

Right now my hypothesis is that the crash prevents the check from cleaning up temporary data.

[joepal1976]

(clicked wrong button, reopening)

[joepal1976]

I think this solves it.