From eca10131d4d70b266e5d8449cf9d72da8180165e Mon Sep 17 00:00:00 2001 From: Niklas Burchhardt Date: Thu, 5 Mar 2026 10:06:07 +0100 Subject: [PATCH 1/3] update CODEOWNERS file - new mails - add johannes, ondrej, andreas, me - remove patrick --- CODEOWNERS | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 7e35182..801e5a7 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1,7 @@ -* patrick.koss@mail.schwarz marius.galm@mail.schwarz simon.stier@mail.schwarz +* marius.galm@digits.schwarz +* simon.stier@digits.schwarz +* florian.sandel@digits.schwarz +* Ondrej.Behavka@digits.schwarz +* Johannes.Moritz@digits.schwarz +* Andreas.Turtschan@digits.schwarz +* niklas.burchhardt@digits.schwarz From e6372082426553d22604a649e9d8aae511343a82 Mon Sep 17 00:00:00 2001 From: Niklas Burchhardt Date: Thu, 5 Mar 2026 13:28:25 +0100 Subject: [PATCH 2/3] update dependencies and divide requirements into dev and install requires so just running doesnt require installing testing/debugging requirements --- certbot_dns_stackit/stackit.py | 5 ++++- setup.py | 14 +++++++++++--- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/certbot_dns_stackit/stackit.py b/certbot_dns_stackit/stackit.py index 0c21580..c9eedd6 100644 --- a/certbot_dns_stackit/stackit.py +++ b/certbot_dns_stackit/stackit.py @@ -363,7 +363,10 @@ def _generate_jwt(self, credentials: ServiceFileCredentials) -> str: } headers = {"kid": credentials["kid"]} return jwt.encode( - payload, credentials["privateKey"], algorithm="RS512", headers=headers # nosemgrep "privateKey" is just the key for the dictionary + payload, + credentials["privateKey"], + algorithm="RS512", + headers=headers, # nosemgrep "privateKey" is just the key for the dictionary ) def _request_access_token(self, jwt_token: str) -> str: diff --git a/setup.py b/setup.py index f665985..ef803b1 100644 --- a/setup.py +++ b/setup.py @@ -9,6 +9,11 @@ "certbot>=2.6.0", "setuptools", "requests", + "click>=8.3.1", + "PyJWT>=2.11.0" +] + +dev_requires = [ "mock", "requests-mock", "mypy", @@ -18,12 +23,9 @@ "flake8", "pydocstyle", "black", - "click==8.3.1", "coverage", - "PyJWT==2.11.0" ] -# read the contents of your README file from os import path this_directory = path.abspath(path.dirname(__file__)) @@ -57,6 +59,9 @@ "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", + "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.13", + "Programming Language :: Python :: 3.14", "Topic :: Internet :: WWW/HTTP", "Topic :: Security", "Topic :: System :: Installation/Setup", @@ -67,6 +72,9 @@ packages=find_packages(), include_package_data=True, install_requires=install_requires, + extras_require={ + "dev": dev_requires, + }, entry_points={ "certbot.plugins": ["dns-stackit = certbot_dns_stackit.stackit:Authenticator"] }, From 101ed53d8c176e0f5b39a1efc58669f57151a75d Mon Sep 17 00:00:00 2001 From: Niklas Burchhardt Date: Wed, 11 Mar 2026 14:06:58 +0100 Subject: [PATCH 3/3] install dev requirements too when setting up venv --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9af3680..83963e4 100644 --- a/Makefile +++ b/Makefile @@ -17,7 +17,7 @@ setup-venv: .PHONY: venv venv: setup-venv - $(VENV_PATH)/bin/pip install -e . + $(VENV_PATH)/bin/pip install -e ".[dev]" .PHONY: build build: venv