Using arrow keys and "-" (minus sign); list of forbidden keybindings?

[rdiaz02]

(At least under Linux) it seems that I cannot bind any script to the arrow keys (with modifiers): e.g., none of Ctrl + Left arrow, or Alt + Left arrow or Shift + Left arrow, work. I can record them when I define the script, but then they do nothing.
I am sure it is not my window manager (XMonad): why? Because I can bind arrows (and modifiers with arrows) to arbitrary actions in, say, Emacs. So the window manager is not intercepting the arrows.
My limited understanding (and gooling around) suggests this is an inherent limitation of Zotero and cannot be worked around. Basically, all shortcuts have to be of the form modifier key(s) + primary printable character, and arrow keys are not primary printable characters. Is this so? [see edit after next comment]
Might it be good to mention in the readme that arrows (with or without modifiers) cannot be used to bind anything?

A similar thing happens to me with the "-" sign. I don't seem to be able to bind scripts to, for example Ctrl and the - (but I can bind scripts to Ctrl and the + sign). Interestingly, if I look at the binding under the advanced config, I see Ctrl,- and, the Shortcut is listed as Ctrl,-, and yet in the editing screen for actions and tags, after saving, it shows as Ctrl. (In contrast, Ctrl with +, the plus sign, works fine). The - should fulfill being a primary printable character but, at least for me, it does not work when binding scripts. (And it does not seem to work either in Windows: see, e.g., #562 (reply in thread))

More generally: if the arrow keys with any modifier and Ctrl - are not possible combinations, maybe they could be added to a "List of forbidden/not available keybindings"?

[windingwind]

Not every shortcut combination works. Technically, as a plugin we can only add an event listener and accept whatever get passed to us. We don't block or forbid any keybindings.

The arrow keys with modifiers are either used by window manager (for my linux desktop, the ctrl - alt - left/right arrow is swtiching workspace), writing (shift - left/right arrow for selection), or app (alt - left/right arrow are go back/foward).

Since these combinations can really vary between different OS and desktops, I don't know how to safely include them in the readme? Because for some people they do work... If you have a good idea, please feel free to PR, though.

[mjthoraval]

Interestingly, if I look at the binding under the advanced config, I see Ctrl,- and, the Shortcut is listed as Ctrl,-, and yet in the editing screen for actions and tags, after saving, it shows as Ctrl.

I also see this problem, which seems to be specific to the plugin?

The shortcut displayed in the Settings is the one just after saving the action.
The one in the Edit Action window is just after trying to edit the action.

[windingwind]

I also see this problem, which seems to be specific to the plugin?

hmm yes. i'll find a fix

[rdiaz02]

Not every shortcut combination works. Technically, as a plugin we can only add an event listener and accept whatever get passed to us. We don't block or forbid any keybindings.

Sorry for the ambiguity: I did not mean that the Actions and Tags forbids or blocks keybindings, but that some keybindings might not be possible at all if, for example, Actions and Tags never gets the see them because Zotero grabs them before (and, of course, if the OS or the window manager grab them).

The arrow keys with modifiers are either used by window manager (for my linux desktop, the ctrl - alt - left/right arrow is swtiching workspace), writing (shift - left/right arrow for selection), or app (alt - left/right arrow are go back/foward).

I am using XMonad for window manager; somewhat similar to you, I have some combos (Win + arrows) that I use with XMonad for window management. But things like Shift/Ctrl/Alt and the arrows are not captured by XMonad; I know, because I can use these other combinations with, for example, Emacs, so my window manager is not blocking or capturing them.

I've actually tried in a Windows virtual machine, and I cannot use the arrows with any of Shift/Ctrl/Alt either; nothing happens.

Since these combinations can really vary between different OS and desktops, I don't know how to safely include them in the readme? Because for some people they do work... If you have a good idea, please feel free to PR, though.

I could PR with a suggestion for a short addition about some shortcuts possibly not working. But I am confused; if I understand correctly, you are saying that some people can use things like Shift/Ctrl/Alt and the arrows as shortcuts for scripts?

Edit: The issue is not, contrary to what I said initially, that shortcuts can only involve modifier keys (Shift/Ctrl/Alt) plus a printable character (letter, digit, symbol); we can have shortcuts with, say Alt + Backspace, and Backspace is not a printable character. But it seems that arrow keys, specifically, never reach the plugin because the Zotero window captures them.

[windingwind]

Thank you for the detailed reply.

The shortcut system Zotero uses (or actually, there's no such system) is hard to describe. There are several different levels of handling, from iframes like reader and note editor, to main window element level key event capture (with sometimes React involved), window level key event capture, and then global XUL key binding. Sometimes you never know from where the event stopped bubbling...

Probably, we can run a sort of "key check" that goes through all possible combinations and see which ones are usable. But that sounds too much.

you are saying that some people can use things like Shift/Ctrl/Alt and the arrows as shortcuts for scripts?

At least for me, the alt - arrow works (only) in readers, in a weird way that also triggers the go back/forward at the same time. It's hard to define if it actually doesn't work (or some people even might use this as a feature?)

Yes anyway having some clarifications would be helpful. PR is welcome.

[rdiaz02]

PR in #565 . Of course, feel free to modify as appropriate.