Fix excessive notifications on match start/end#111
Merged
Conversation
Filters notifications to: WaitingForCheckIn, Live, Finished, Tie, Canceled, Forfeit, Surrendered. Skips PickingPlayers, Scheduled, WaitingForServer, Veto. Fixes #347
Moves the status whitelist to utilities/constants.ts alongside other notification constants. Uses ReadonlySet for immutability.
Previously used 'role IS NOT NULL' which matched every notification in the system. Now admins only see their personal notifications plus those with role=administrator. Fixes #347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role IS NOT NULL(matched every notification in the system) torole = administratorTest plan
Fixes 5stackgg/5stack-panel#347