Update ValuesUtilities.GetValuesFor to support all primitives#156
Open
John-Leitch wants to merge 1 commit intoAArnott:mainfrom
Open
Update ValuesUtilities.GetValuesFor to support all primitives#156John-Leitch wants to merge 1 commit intoAArnott:mainfrom
ValuesUtilities.GetValuesFor to support all primitives#156John-Leitch wants to merge 1 commit intoAArnott:mainfrom
Conversation
John-Leitch
changed the title
ValuesUtilities.GetValuesFor to support all primitives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #155. Rather than checking for specific types, a more generalized solution was achieved by checking
Type.IsPrimitiveand then usingConvert.ChangeTypeto return0and1. This works with not onlyboolandint, but all primitives, such assbyteanddouble.