Use decoded value as s3 key so requests dont fail#1462
Closed
subkanthi wants to merge 7 commits intoAltinity:antalya-25.8from
Closed
Use decoded value as s3 key so requests dont fail#1462subkanthi wants to merge 7 commits intoAltinity:antalya-25.8from
subkanthi wants to merge 7 commits intoAltinity:antalya-25.8from
Conversation
arthurpassos
reviewed
Mar 2, 2026
src/Storages/ObjectStorage/Utils.cpp
Outdated
| S3::URI s3_uri(normalized_path); | ||
|
|
||
| std::string key_to_use = s3_uri.key; | ||
|
|
Collaborator
There was a problem hiding this comment.
I think a comment would be very helpful for future readers of this code
…s' into fix_iceberg_comments
arthurpassos
approved these changes
Mar 3, 2026
Collaborator
arthurpassos
left a comment
arthurpassos
left a comment
There was a problem hiding this comment.
LGTM, tho we need to wait for CICD and someone with merge rights (I don't have it)
|
@arthurpassos is it possible to have this fix in the next release ? Thanks a lot. By the way, I started to fix this but I was not if I needed to add test for it :( @subkanthi was faster. Hope next time I can contribute. |
Collaborator
|
@subkanthi I am afraid our external contributor workflow for 25.8 is not alive (yet). Please, re-make this PR from a branch in Altinity repo (like #1492) |
zvonand
requested changes
Mar 11, 2026
Collaborator
zvonand
left a comment
zvonand
left a comment
There was a problem hiding this comment.
CI seems to be broken, pls resubmit it from a branch in Altinity repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1348
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use encoded s3 uri for key so the subsequent requests succeeds.
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: