Conversation
… and npmrc configuration
Contributor
Review Summary by QodoAdd Node.js versions 25.8.0, 24.14.0, and 22.22.1 with configurations
WalkthroughsDescription• Add Node.js versions 25.8.0, 24.14.0, and 22.22.1 • Create launch scripts and configuration files for new versions • Update release properties with download URLs for new versions • Update bundle release date to 2026.3.7 Diagramflowchart LR
A["New Node.js Versions<br/>25.8.0, 24.14.0, 22.22.1"] --> B["Launch Scripts<br/>launch.bat"]
A --> C["Configuration Files<br/>bearsampp.conf, npmrc"]
B --> D["Environment Setup<br/>npm config"]
C --> E["npm Paths & Cache<br/>etc/npmrc"]
F["releases.properties"] --> G["Download URLs<br/>2026.3.7 release"]
H["build.properties"] --> I["Bundle Date Update<br/>2026.3.7"]
File Changes1. bin/nodejs22.22.1/launch.bat
|
Contributor
Code Review by Qodo
1. Unquoted npmrc redirection
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+8
to
+10
| ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH% | ||
|
|
||
| "%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global |
Contributor
There was a problem hiding this comment.
1. Unquoted npmrc redirection 🐞 Bug ⛯ Reliability
Newly added launch.bat files write npmrc via unquoted output redirection, which will break when the install path contains spaces (common on Windows), causing npm prefix/globalconfig setup to fail.
Agent Prompt
## Issue description
`launch.bat` writes to `%BEARSAMPP_NODEJS_CONFIG_PATH%` using an unquoted redirection target. This can fail when the Bearsampp install path contains spaces.
## Issue Context
This PR adds new `launch.bat` files for Node.js 22.22.1 / 24.14.0 / 25.8.0. The same repo already contains a safer quoted redirection pattern in `bin/archived/nodejs20.19.5/launch.bat`.
## Fix Focus Areas
- bin/nodejs22.22.1/launch.bat[4-11]
- bin/nodejs24.14.0/launch.bat[4-11]
- bin/nodejs25.8.0/launch.bat[4-11]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.