Handle ElementsRegtest in test context instead of panicking#35
Merged
Arvolear merged 1 commit intoBlockstreamResearch:devfrom Mar 24, 2026
Merged
Conversation
- Add ElementsRegtest case to network match (maps to default_regtest()) - Return BadNetworkName error for invalid network values instead of panic - Add unit test for invalid network error handling - Align error message with CLI config validation Made-with: Cursor
panditdhamdhere
force-pushed
the
fix-elementsregtest-handling
branch
from
3a2e1c8 to
a664963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, using
ElementsRegtestas the network in the test config (esplora-only mode) caused a panic with "Impossible branch reached". Invalid network values (e.g. typos) also panicked instead of returning a clear error.Changes
Add ElementsRegtest case to network match (maps to default_regtest())
Return BadNetworkName error for invalid network values instead of panic
Add unit test for invalid network error handling
Align error message with CLI config validation
This PR suggests a bug fix and I've added the necessary tests.