FIREFLY-1935: Alert Viewer by kpuriIpac · Pull Request #1917 · Caltech-IPAC/firefly

kpuriIpac · 2026-03-03T01:08:46Z

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1935

Implement Alert Viewer template
Improved server side logic by adding a search processor based on feedback
The processor retrieves & downloads the file, and then uses the existing AlertAnalyzer, then returns the parts (2 tables and 3 images) back to client as JSON
- each JSON entry also includes the file location, in case we support multiple (more than one) files later
This in turn simplifies the client-side code inside AlertUploadPanel
Using the same viewerId and only one call to MultiImageViewer for images now
ToDo: some basic cleanup left to do including fixing heights of the 2 tables
Note: The search processor currently only supports URLs, but I have some commented out code (marked with a todo) ready to accept Alert IDs as well. This should be pretty easy to enable once we have working examples of Alert IDs (and the service to call with those IDs).

Test build: Alert Viewer: https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

files you can use to test upload:
- https://web.ipac.caltech.edu/staff/roby/alert-test/al-test-2.fits
- https://web.ipac.caltech.edu/staff/roby/alert-test/coadd-1-100-thru20210505.fits

loitly

The UI still needs some polishing, which is expected. Moving the logic to the server side is a good improvement. I think we should talk offline to fully flesh out what the new interface should look like.
@robyww should review the multiProduct changes.

loitly · 2026-03-12T15:47:42Z

src/firefly/html/alertviewer.html

+    <title>Alert Viewer</title>
+
+    <script>
+        var pOpts = window.firefly && window.firefly.options || {};


loitly · 2026-03-12T15:55:59Z

src/firefly/js/apps/alertviewer/AlertResultView.jsx

+        }}>
+
+            {/* Top: tables */}
+            <Box sx={{display: 'flex', flex: '1 1 0%', gap: 1, p: 1, overflow: 'hidden', minHeight: 0, minWidth: 0,


Why is Box with display=flex used throughout? Would it be easier to use Stack?

loitly · 2026-03-12T16:09:21Z

src/firefly/js/apps/alertviewer/AlertUploadPanel.jsx

+                            isFromURL={true}
+                            canDragDrop={false}
+                            fileAnalysis={onLoading}
+                            uploadParams={{analyzerId: 'alert'}} //triggers server alert analyzer


Not exactly what I had in mind, but I could be wrong. Let's talk offline.

loitly · 2026-03-12T16:11:02Z

src/firefly/js/ui/FileUpload.jsx

            onChange: (ev) => onUrlChange(ev, viewProps, fireValueChange),
            value:  viewProps.displayValue,
-            onUrlAnalysis: (value) => doUrlAnalysis(value, fireValueChange, fileType, viewProps.fileAnalysis)
+            onUrlAnalysis: (value) => doUrlAnalysis(value, fireValueChange, fileType, viewProps.fileAnalysis, viewProps.uploadParams)


I think it could be done without having to change FileUpload.

robyww · 2026-03-20T16:38:17Z

@kpuriIpac I brought up the test. The alert tab does not appear to be enabled.

kpuriIpac · 2026-03-20T17:49:42Z

https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

@robyww can you try again? it's still working for me: https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

robyww

(Mostly UI feedback with a couple of code comments. I will look at the code more on Monday.)

UI Feedback:

I think you should use the DockLayoutPanel for the three views. I think it is pretty each to use since it does layout this way by default. See line 67 of ResultsPanel.jsx
pad the right side table down so it better aligns with the left side table
remove Scroll Images: Create a prompt on MultiViewStandardToolbar to disable this features. The toolbar get all the props passed to MultiImageViewer.

robyww · 2026-03-20T16:52:15Z

src/firefly/js/visualize/ui/MultiImageViewerView.jsx

+        ? {flex: '1 1 0%', minHeight: 0, height: '100%', maxWidth: '100%', overflow: 'hidden'}
+        : {width: '100%', height: '100%'};


I am surprise this change was necessary.

robyww · 2026-03-20T20:52:38Z

src/firefly/js/apps/alertviewer/AlertResultView.jsx

+                    )}
+                </Box>
+
+                <Box sx={{flex: '1 1 0%', overflow: 'hidden', minHeight: 0, minWidth: 0}}>


also I wee you adding minHeight:0, minWidth: 0. I don't see why this is necessary.

robyww · 2026-03-20T20:53:58Z

src/firefly/js/apps/alertviewer/AlertUploadPanel.jsx

+
+    return (
+        <Stack width={1} alignItems='center'>
+            <Stack ml={0} mt={4} spacing={3} sx={{position: 'relative'}}>


why ml=0?
also since youu are declaring a sx you should put the style in there.

robyww · 2026-03-20T20:54:54Z

src/firefly/js/apps/alertviewer/AlertResultView.jsx

+                            viewerId={ALERT.IMG_VIEWER}
+                            insideFlex={true}
+                            forceRowSize={1}
+                            Toolbar={MultiViewStandardToolbar}


add the prop for MultiViewStandardToolbar here

kpuriIpac · 2026-03-24T01:09:59Z

@robyww I implemented the feedback, using DockLayoutPanel now, and cleaned up the styling a lot (unnecessary use of Box, some minHeight / minWidth - lot of it left over from my initial work & testing to make the layout work, but not really required).

One UI bug that I tried to fix today but couldn't: When you expand images (full screen) and Close the expanded mode, the images don't render (but you still see the images toolbar). If you interact with either the toolbar or either one of the tables, the images show up again. Trying to put in a fix for this soon. But otherwise the code is ready for review. Test build updated.

kpuriIpac self-assigned this Mar 3, 2026

kpuriIpac added the enhancement label Mar 3, 2026

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 6 times, most recently from 41c2af3 to cf5a5a3 Compare March 11, 2026 22:27

kpuriIpac requested a review from loitly March 11, 2026 22:30

loitly reviewed Mar 12, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 3 times, most recently from ddc105d to 97be20a Compare March 19, 2026 20:32

kpuriIpac marked this pull request as ready for review March 19, 2026 20:33

kpuriIpac requested a review from robyww March 19, 2026 20:55

robyww reviewed Mar 20, 2026

View reviewed changes

kpuriIpac and others added 10 commits March 23, 2026 16:00

alert viewer draft

cb5aa67

some more cleanup

26c4bdc

switch to router template

fad30cd

cleanup and make routed app work

1cfb8e0

fix broken charts

72c1939

alert ids history dialog

0700c83

fix basename bug

c078c58

implement server side processing

a1f09b7

alerts logic improvement server side

93628f0

minor fixes and cleanup

f38c4bf

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 2 times, most recently from a841da8 to 66af329 Compare March 24, 2026 00:40

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 3 times, most recently from 3aa49cd to 518377d Compare March 24, 2026 00:43

cleanup styles and implement more feedback

0a657fa

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch from 518377d to 0a657fa Compare March 24, 2026 01:06

		? {flex: '1 1 0%', minHeight: 0, height: '100%', maxWidth: '100%', overflow: 'hidden'}
		: {width: '100%', height: '100%'};

Conversation

kpuriIpac commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loitly left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robyww commented Mar 20, 2026

Uh oh!

kpuriIpac commented Mar 20, 2026

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

UI Feedback:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kpuriIpac commented Mar 3, 2026 •

edited

Loading