Allow definition of both codspeed exec and codspeed entrypoint targets in project config#260
Open
GuillaumeLagrange wants to merge 3 commits intomainfrom
Conversation
…ocal The orchestrator is now able to feed structured metadata that will be appended to the run_part_id. For now, we are just adding the executor, but in next commits when we'll start having mixed entrypoints the orchestrator will be able to differentiate which run_part is which.
We now build Orchestrator config from cli args and profile config, and then the orchestrator is in charge of spawning the appropriate executor config when running an executor. An ExecutorConfig is only valid to run a single command in a single mode, while the OrchestratorConfig is what defines all commands and modes that will be run in a single CLI invocation.
GuillaumeLagrange
force-pushed
the
cod-2009-define-both-codspeed-exec-and-codspeed-entrypoint-targets-in
branch
from
9fd4cda to
0662118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify
run_part_idsuffix computation between CI providers and local — The orchestrator now feeds structured metadata appended to therun_part_id, starting with the executor name, so all providers share the same suffix logic.Introduce
OrchestratorConfigandExecutorConfig— Separated run-level config (all commands and modes for a single CLI invocation) from per-execution config (a single command in a single mode), with the orchestrator responsible for spawning the appropriate executor config.Accept a mix of
entrypointandexectargets in project config — Allexectargets are combined into a single exec-harness invocation, while eachentrypointtarget runs independently, both multiplied across all configured modes.