Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Waiting for authorization...because the local callback loop blocked onlistener.accept().awaitand missed an authorizationcodewritten by the spawned request handler, causing the spinner to never detect completion.Description
start_callback_serverwith atokio::select!that interleaveslistener.accept()and a short timer tick so the loop can check the sharedauth_codestate frequently.auth_codecheck outside theaccept()path so the server returns immediately when the handler stores the code, and keep the spawned task that serves each incoming connection intact.src/authorize.rsto improve readability around the callback handling logic.Testing
cargo testwhich completed successfully (no failing tests in the repo).cargo fmt --checkwhich reported formatting differences (repository has broader formatting drift, so formatting was not applied as part of this bugfix).Codex Task