Skip to content

Fix icon database load on .NET 10#4476

Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intomainfrom
fix-icon-database
Mar 14, 2026
Merged

Fix icon database load on .NET 10#4476
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intomainfrom
fix-icon-database

Conversation

@mamoreau-devolutions

Summary

  • stop reusing the shared JSON serializer options when constructing the updater source-generated context
  • keep the shared serializer options resolver generic so the icon screenshot database can still deserialize on .NET 10
  • add a regression meta-test to prevent future JsonSerializerContext construction from rebinding the shared options instance

Validation

  • dotnet test 'src/UniGetUI.Core.Tools.Tests/UniGetUI.Core.Tools.Tests.csproj' --no-restore --verbosity minimal
  • dotnet build 'src/UniGetUI/UniGetUI.csproj' --no-restore -v q

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) merged commit 8757d9f into main Mar 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants