Patch compatibility: Power Mode 2003#3384
Patch compatibility: Power Mode 2003#3384florianessl wants to merge 10 commits intoEasyRPG:masterfrom
Conversation
e1e4ae3 to
20ca728
Compare
ghost
left a comment
There was a problem hiding this comment.
Besides -Wunused warnings, looks good to me!
Related: #634 |
20ca728 to
cb772cb
Compare
|
Button mapping for Mouse L/R is now also implemented. This fixes a screen for this Spanish zelda fangame: https://www.hellsoft.net/H5/component/remository/Juegos/Rpg-Maker-2003/The-Legend-of-Zelda-Necklace-of-Elements/?Itemid=537 |
| } | ||
| continue; | ||
| } | ||
| if (cp.ParseNext(arg, 0, { "--patch-powermode", "--no-patch-powermode" })) { |
There was a problem hiding this comment.
This needs to be documented (manual, help message)
There was a problem hiding this comment.
There's already a line for this patch option in the help message.
I don't have any idea about the state of the online manual - probably way out of date.
There was a problem hiding this comment.
yeah the manual (manpage) is usually a bit behind because we forget updating it. I usually copy everything over before the next release xD.
Thanks for the PR. Will review it next week.
…01] - V[0007] (Special commands, Mouse Input, Extended Keyboard input & floating point arithmetic)
…ode to game_runtime_patches.cpp & Implemented the L/R button bindings for PowerMode2003
…ing: Pressing L/R versions of SHIFT/CTRL/ALT should always return the generic keycode (Lowest keycode takes precedence when checking for 'any' key press)
…le key lookup method
5fa3c0e to
468f2cb
Compare
Ghabry
left a comment
There was a problem hiding this comment.
Looks good. 👍 Nice approach with these callback functions.
Also the RuntimePatches namespace itself has no state (except for this one mouse binding thing) so keeping it as a namespace is fine. Not much to clean up here
This PR adds compatibility for the PowerMode 2003 patch.
Other than the missing support for AAC audio files
& the mapping of mouse buttons,this patch implementation should be feature-complete. (and less buggy than the original patch)Depends on PR #3378 because I didn't want to create a new file for this implementation alone.
I did some research on this obscure patch & documented my findings in more detail on Makerpendium:
https://www.makerpendium.de/index.php?title=PowerMode_2003
There's an article on Hellsoft about this patch, that also includes a small sample project:
https://www.hellsoft.net/H5/reportajes/95-reportajes-especiales/150-power-mode-2003
Implemented features
(Start of variable range stored in V08:SPECIAL - Block of 50 variables containing set rotation degrees from 0 - 256)
Support for AAC files(Not implemented - should be part of another PR)(Standard picture rotation effect will be applied counter-clockwise if this value is abova 49)