You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have updated data and added (hopefully) all missing examples, but I have noticed some bugs:
The new support for all commands is nice, but changes of window size cause some blurring do to rescaling, which is carried over to other examples. Possible solutions:
Filter out that command
Reset size after loading a different example
Remove the command from the streams (the only bad guys are distance.saved, shifted.saved and ex6-dofs-numbering.saved)
Remove the examples
Loading example 22 (vector) gives different results sometimes, not clear what is happening
Ok, I fixed the resolution problem, so all examples can be loaded 👍 .
That example 22 - vector depends on timing, sometimes U key is ignored 😬 . That is a bug in GLVis itself and has nothing (directly) to do with glvis-js or complex functions visualization. It is just the only example, which uses U key. Anyway, I would leave it for now and proceed. We will just know one of the examples is a bit funky 🤪 .
Ok, I think it is pretty clear what is happening for U, it uses static variables, which are initialized only once, which is fine for native GLVis, but the web live version generates new instances of visualization scenes, which do not reinit these static variables. We should really get rid of these 🤢 . I will open a PR in GLVis, but we may merge this independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to glvis-js v0.5