Skip to content

feat: add subresource integrity to import map#204

Open
CallumNZ wants to merge 1 commit intomainfrom
importMapIntegrity
Open

feat: add subresource integrity to import map#204
CallumNZ wants to merge 1 commit intomainfrom
importMapIntegrity

Conversation

@CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented Mar 9, 2026

Reference: https://github.com/GeoNet/tickets/issues/19393

Changes proposed in this pull request:

  • Add integrity value for js module files in import map.

Note: Tested by changing the SRI value to something wrong in the import map, the browser refuses to run it.

Adding this means we can remove all the subResourcePreload lines from www-geonet border.html, while still keeping subresource integrity for those scripts.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested a review from bpeng March 9, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant