Skip to content

Fix Storage's storeSize calculation when overwriting existing key #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbri merged 1 commit into from
Mar 12, 2026
+3 −1
Merged

Fix Storage's storeSize calculation when overwriting existing key #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/htmlunit/javascript/host/Storage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
* @author Ahmed Ashour
* @author Marc Guillemot
* @author Ronald Brill
* @author Kanoko Yamamoto
*/
@JsxClass
public class Storage extends HtmlUnitScriptable {
Expand Down Expand Up @@ -164,7 +165,8 @@ public Object getItem(final String key) {
*/
@JsxFunction
public void setItem(final String key, final String data) {
final long storeSize = storeSize_ + data.length();
final String existingData = store_.get(key);
final long storeSize = storeSize_ + data.length() - (existingData != null ? existingData.length() : 0);
if (storeSize > STORE_SIZE_KIMIT) {
throw JavaScriptEngine.throwAsScriptRuntimeEx(
new DOMException((short) 22, "QuotaExceededError: Failed to execute 'setItem' on 'Storage': "
Expand Down
Loading