Ensure that converted objects are pinned to avoid invalid accesses due to memory movement#117
Open
Braedon-Wooding-Displayr wants to merge 1 commit intoJavascriptNet:masterfrom
Conversation
…e to memory movement
|
|
||
| ConvertedObjects::~ConvertedObjects() | ||
| { | ||
| // Delete gcroot pointers using C++ vector - no V8 operations needed. |
There was a problem hiding this comment.
gc roots don't pin the memory so we can't hold them as ptrs.
This is only really safe right now is because memory only moves for long lived memory (short lived memory never moves) and all these converted objects fall under short lived memory.
oliverbock
approved these changes
Mar 13, 2026
Contributor
oliverbock
left a comment
oliverbock
left a comment
There was a problem hiding this comment.
Looks like a good change, though it's been a long time since I've used any of this stuff so I might be wrong. Perhaps check with Brandon too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't trust gc_root since it doesn't pin the memory so we need to use pin_ptr or gc handle. I've opted for gc handle here for no specific reason.