Skip to content

Re-instate ability to provide multiple revs eg diffuse -r v1 -r v2 file#248

Merged
MightyCreak merged 3 commits intoMightyCreak:mainfrom
bhepple:multiple-revs
Mar 11, 2026
Merged

Re-instate ability to provide multiple revs eg diffuse -r v1 -r v2 file#248
MightyCreak merged 3 commits intoMightyCreak:mainfrom
bhepple:multiple-revs

Conversation

@bhepple
Copy link
Contributor

@bhepple bhepple commented Apr 25, 2025

fix for #246

@GregLawson
Copy link

Wow! Is that all the changes it takes? The ability to have multiple -t options disappeared at the same time, any possibility it is as easy to restore? I'll have to figure out how to test this PR!

@Ansa211
Copy link

Ansa211 commented May 1, 2025

@bhepple I am really looking forward for this to be merged. Just as @GregLawson mentioned, multiple related issues were introduced at the same time (#213, #214), does your solution work for them as well / could it be easily adjusted? So far the suggested solution was to go back with the old option parser: #214 (comment)

@bhepple
Copy link
Contributor Author

bhepple commented May 1, 2025

It's not going to be that simple, I think. The --tab/--separate options are of type G_OPTION_ARG_NONE rather than G_OPTION_ARG_STRING - I got lucky with changing the --revision option to G_OPTION_ARG_STRING_ARRAY and found that the processing was already in place for it.

While I'm no expert on processing Gtk.Application options, it seems it processes all options first and then all the command line arguments quite separately. I think the old code processed them together and was able to that smart thing you want - so yeah, maybe going back to the old code or equivalent might be the only way.

@MightyCreak MightyCreak force-pushed the multiple-revs branch 2 times, most recently from 125b541 to 0e3c14d Compare March 10, 2026 23:48
@MightyCreak
Copy link
Owner

I'm fighting with Github's CI/CD, but as soon as the PR is green, I'll approve

@MightyCreak MightyCreak merged commit 5d8638b into MightyCreak:main Mar 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants