Skip to content

Deterministic SQL result ordering #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbcoe wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −4
Open

Deterministic SQL result ordering #109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8a22d2
Revert "Fast rebuilds of C/C++ code when needed. (#106)"
jbcoe Mar 20, 2026
aaedc96
Added explicit ORDER BY .gameid to SQL queries to ensure deterministi…
jbcoe Mar 21, 2026
c07093b
Merge remote-tracking branch 'upstream/main' into jbcoe/sort-sql-results
jbcoe Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions nle/dataset/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,29 +211,33 @@ def __init__(
SELECT ttyrecs.gameid, ttyrecs.part, ttyrecs.path
FROM ttyrecs
INNER JOIN datasets ON ttyrecs.gameid=datasets.gameid
WHERE datasets.dataset_name=?"""
WHERE datasets.dataset_name=?
ORDER BY ttyrecs.gameid"""

meta_sql = """
SELECT games.*
FROM games
INNER JOIN datasets ON games.gameid=datasets.gameid
WHERE datasets.dataset_name=?"""
WHERE datasets.dataset_name=?
ORDER BY games.gameid"""

if subselect_sql:
path_select = """
SELECT ttyrecs.gameid, ttyrecs.part, ttyrecs.path
FROM ttyrecs
INNER JOIN datasets ON ttyrecs.gameid=datasets.gameid
WHERE datasets.dataset_name=?
AND ttyrecs.gameid IN (%s)"""
AND ttyrecs.gameid IN (%s)
ORDER BY ttyrecs.gameid"""
core_sql = path_select % subselect_sql

meta_select = """
SELECT games.*
FROM games
INNER JOIN datasets ON games.gameid=datasets.gameid
WHERE datasets.dataset_name=?
AND games.gameid IN (%s)"""
AND games.gameid IN (%s)
ORDER BY games.gameid"""
meta_sql = meta_select % subselect_sql
sql_args = subselect_sql_args if subselect_sql_args else ()
sql_args = (dataset_name,) + sql_args
Expand Down
Loading