[14.0][IMP] account_invoice_facturx: add support for negative price#1224
Open
alexis-via wants to merge 3 commits intoOCA:14.0from
Open
[14.0][IMP] account_invoice_facturx: add support for negative price#1224alexis-via wants to merge 3 commits intoOCA:14.0from
alexis-via wants to merge 3 commits intoOCA:14.0from
Conversation
Remove @api.model on _cii_trade_contact_department_name() and _cii_trade_agreement_buyer_ref() because, in some inherits of those methods, we might read the info directly from the invoice itself.
Invoice lines with negative prices are now global allowance lines Fix per-line allowance node "ActualAmount" Improve per-line allowance node: add "CalculationPercent" and "BasisAmount" nodes
…lAmount is not null
jbaudoux
reviewed
Oct 10, 2025
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
There are pre-commit issues :/
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1139
It includes a fix for LineTotalAmount when AllowanceTotalAmount is not null