Merged
Conversation
jonjenssen
force-pushed
the
tiein_valve
branch
2 times, most recently
from
6fc95f2 to
34f908d
Compare
Add python test for custom outlet valve md Add python example
Co-authored-by: jonjenssen <69144954+jonjenssen@users.noreply.github.com>
Add python example and test
magnesj
approved these changes
Mar 6, 2026
Member
magnesj
left a comment
magnesj
left a comment
There was a problem hiding this comment.
Very good, well organized an easy to read code.
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13503
Support using custom MD for tie-in valve
Show valve in 3D views
Add python API for new valve functionality
Add open/close flag to valves
Add standalone ICV valve support
Framework: Add support for std::pair<bool, some_type> on Python side as tuples.