Updated Get Octopus Usage template to match new script#1613
Merged
hnrkndrssn merged 3 commits intomasterfrom Aug 31, 2025
Merged
Updated Get Octopus Usage template to match new script#1613hnrkndrssn merged 3 commits intomasterfrom
hnrkndrssn merged 3 commits intomasterfrom
Conversation
Updates changes to step template reflected in OctopusDeploy/OctopusDeploy-Api#242
|
Start Hyponome locally |
hnrkndrssn
requested changes
Aug 29, 2025
Contributor
hnrkndrssn
left a comment
There was a problem hiding this comment.
The script configures the Security Protocol twice, which may not give the expected result:
# Add support for TLS 1.2
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls12
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls13
It should probably be updated to be on just the one statement if we want to ensure both TLS1.2 and TLS1.3 enabled:
# Add support for both TLS 1.2 and TLS 1.3
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12 -bor [System.Net.SecurityProtocolType]::Tls13
Contributor
Author
|
Good catch @hnrkndrssn - I've made that update in 7478b57
|
hnrkndrssn
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates changes to the step template "Get Octopus Usage" reflected in OctopusDeploy/OctopusDeploy-Api#242