Skip to content

wpmldev-4407: PHP 8.4 compatibility #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegarc-otgs wants to merge 2 commits into
base: wpmldev-1615
Choose a base branch
from
Open

wpmldev-4407: PHP 8.4 compatibility #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda5caa
wpmldev-4407: PHP 8.4 compatibility
diegarc-otgs Feb 27, 2026
7ce9beb
wpmldev-4407: PHP 8.4 compatibility
diegarc-otgs Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,12 +595,12 @@ public function parse()
* Creates a new error log.
*
* @param string $msg the error message
* @param Token $token the token that produced the error
* @param Token|null $token the token that produced the error
* @param int $code the code of the error
*
* @throws ParserException throws the exception, if strict mode is enabled
*/
public function error($msg, Token $token = null, $code = 0)
public function error($msg, ?Token $token = null, $code = 0)
{
$error = new ParserException(
Translator::gettext($msg),
Expand Down
6 changes: 3 additions & 3 deletions src/Statement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ abstract class Statement
/**
* Constructor.
*
* @param Parser $parser the instance that requests parsing
* @param TokensList $list the list of tokens to be parsed
* @param Parser|null $parser the instance that requests parsing
* @param TokensList|null $list the list of tokens to be parsed
*/
public function __construct(Parser $parser = null, TokensList $list = null)
public function __construct(?Parser $parser = null, ?TokensList $list = null)
{
if (($parser !== null) && ($list !== null)) {
$this->parse($parser, $list);
Expand Down