feat: Adds creek intake to SurgeTank model#84
Open
dietmarw wants to merge 6 commits intoOpenSimHub:masterfrom
Open
feat: Adds creek intake to SurgeTank model#84dietmarw wants to merge 6 commits intoOpenSimHub:masterfrom
dietmarw wants to merge 6 commits intoOpenSimHub:masterfrom
Conversation
Make the height of the creek intake configurable Correct the pressure calculation of the creek intake Updated parameter names and add example Use conditional internal connector moves mdot to general mdot equation use if and connector Use modifications for conditional equations. Removed BottomVolume again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a new feature to allow modeling of lateral water inflows, such as creeks or groundwater seepage, into a surge tank. This enhances the realism and applicability of the
SurgeTankcomponent in hydropower simulations.useCreekIntakeparameter that, when activated, exposes a newcreekconnector. TheH_creekparameter defines the height of this intake. The model's mass balance equation is updated to correctly include the creek inflow.SimpleValveWithCreek, a new example model demonstrating how to utilize the creek intake feature.SurgeTankmodel, updates the text placement on theSurgeicon, and removes an outdated literature reference from the documentation.