Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds --what-if support to the dsc resource delete CLI flow, wiring the flag from argument parsing through subcommand dispatch into the resource invocation layer, and validating behavior with a new PowerShell test.
Changes:
- Add
--what-if(and-w) todsc resource deleteand plumb it through toresource.delete(..., ExecutionKind::WhatIf). - Add delete-command output formatting support and emit structured output for delete what-if results.
- Add a Pester test asserting
dsc resource delete --what-ifreturns delete what-if metadata.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dsc/tests/dsc_whatif.tests.ps1 | Adds a Pester test validating dsc resource delete --what-if output contains delete what-if messages. |
| dsc/src/args.rs | Extends resource delete CLI args with --what-if and --output-format. |
| dsc/src/subcommand.rs | Plumbs new delete args into the resource_command::delete call. |
| dsc/src/resource_command.rs | Implements what-if execution kind for delete and prints structured output for what-if results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteveL-MSFT
requested changes
Mar 11, 2026
Co-authored-by: Steve Lee <slee@microsoft.com>
SteveL-MSFT
approved these changes
Mar 11, 2026
Member
|
@tgauth can you fix the merge conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
--what-ifand--output-formatargs todsc resource deletecommand