Skip to content

SBND Timing Reconstruction Refactor#915

Open
VCLanNguyen wants to merge 51 commits intodevelopfrom
feature/frame_shift_refactor_v10_14_02
Open

SBND Timing Reconstruction Refactor#915
VCLanNguyen wants to merge 51 commits intodevelopfrom
feature/frame_shift_refactor_v10_14_02

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Feb 14, 2026

Description

  • Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
  • After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
  • Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
  • The timing correction applied at CAFMakeer is undone.
  • Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45982

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
#847

This PR needs to be merged together with this group of PRs:

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

aliciavr and others added 30 commits October 9, 2025 04:05
aliciavr and others added 8 commits February 12, 2026 16:42
…ess its products. Additionally, set a frameshift mode boolean t be activated when selecting the frameshift timestamp (this one to be integrated in the workflow)
…frame to FRAMESHIFT or CAEN-only. Integrate FRAMESHIFT timing frame into the workflow and output products
…fline-decoder-v5.0-frameshift-refactor

Feature/aliciavr xarapuca offline decoder v5.0 frameshift refactor
@VCLanNguyen VCLanNguyen marked this pull request as draft February 14, 2026 00:13
@VCLanNguyen VCLanNguyen self-assigned this Mar 4, 2026
@VCLanNguyen VCLanNguyen added crt Cosmic Ray Tagger breaking change pds Photon Detection System caf Common analysis framework data features for data processing labels Mar 4, 2026
@VCLanNguyen VCLanNguyen changed the title Feature/frame shift refactor v10 14 02 Timing Reconstruction Refactor Mar 4, 2026
@VCLanNguyen VCLanNguyen changed the title Timing Reconstruction Refactor SBND Timing Reconstruction Refactor Mar 4, 2026
@VCLanNguyen VCLanNguyen marked this pull request as ready for review March 4, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change caf Common analysis framework crt Cosmic Ray Tagger data features for data processing pds Photon Detection System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants