Move dormant_capable? from Parser to cycle classes#73
Open
Conversation
Each cycle class now declares its own dormant capability: def self.dormant_capable? = true # EndOf, Within def self.dormant_capable? = false # Cycle base (default) Parser.dormant_capable_kinds now derives the list from Cycle.cycle_handlers instead of a hardcoded array. This means adding a new dormant-capable cycle kind only requires declaring dormant_capable? on the class — no separate Parser edit needed.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses jdowd's feedback from #69:
Each cycle class now declares its own dormant capability alongside
recurring?:Parser.dormant_capable_kindsnow derives the list from the cycle classes instead of a hardcoded array. Adding a new dormant-capable cycle kind only requires declaringdormant_capable?on the class — no separate Parser edit needed.Before
To make a cycle dormant-capable, you had to:
Parser.dormant_capable_kinds = %w[E W]After
Just declare it on the class:
Test plan
No behavior change — this is a mechanical refactor that makes cycle classes self-describing.