Skip to content

Fix macOS name in the devices tab from 'Mac OS' to 'macOS'#328

Merged
dozro merged 5 commits intoSableClient:devfrom
DidiDidi129:dev
Mar 17, 2026
Merged

Fix macOS name in the devices tab from 'Mac OS' to 'macOS'#328
dozro merged 5 commits intoSableClient:devfrom
DidiDidi129:dev

Conversation

@DidiDidi129
Copy link
Contributor

@DidiDidi129 DidiDidi129 commented Mar 17, 2026

Description

Fixed the issue where mac users would have their device name be Mac OS instead of macOS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copilot AI review requested due to automatic review settings March 17, 2026 06:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates macOS detection in the user-agent utility, intended to align the OS name handling with “macOS”.

Changes:

  • Changed the isMac OS-name comparison from 'Mac OS' to 'macOS'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dozro
Copy link
Member

dozro commented Mar 17, 2026

you might want to convert your pr to a draft while working on it :)

and i updated the title, to be a bit more clear, feel free to adjust it iyw

@dozro dozro changed the title Fix macOS name from 'Mac OS' to 'macOS' Fix macOS name in the devices tab from 'Mac OS' to 'macOS' Mar 17, 2026
@DidiDidi129 DidiDidi129 marked this pull request as draft March 17, 2026 07:18
@DidiDidi129 DidiDidi129 marked this pull request as ready for review March 17, 2026 08:05
@DidiDidi129
Copy link
Contributor Author

Right everyone just ignore the earlier commits, I misunderstood the code.

Trial and error fixed things though 👍

@DidiDidi129
Copy link
Contributor Author

you might want to convert your pr to a draft while working on it :)

and i updated the title, to be a bit more clear, feel free to adjust it iyw

Thank you, I did 🫡

PS deleted a bunch of unnecessary comments for clarity to any reviewers lol

Copy link
Member

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dozro dozro enabled auto-merge March 17, 2026 08:57
@dozro dozro added this pull request to the merge queue Mar 17, 2026
Merged via the queue into SableClient:dev with commit 9ed985a Mar 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants