Increase poll log interval to reduce log spam#541
Draft
kmontemayor2-sc wants to merge 5 commits intomainfrom
Draft
Increase poll log interval to reduce log spam#541kmontemayor2-sc wants to merge 5 commits intomainfrom
kmontemayor2-sc wants to merge 5 commits intomainfrom
Conversation
svij-sc
approved these changes
Mar 11, 2026
gigl/distributed/utils/networking.py
Outdated
| Supports both GcsUri (production) and LocalUri (testing). | ||
| timeout: Maximum time in seconds to wait for the signal. Defaults to 3600. | ||
| poll_interval: Time in seconds between poll attempts. Defaults to 10. | ||
| log_every_n_attempts: Number of attempts between log messages. Defaults to 60. |
Collaborator
There was a problem hiding this comment.
Suggested change
| log_every_n_attempts: Number of attempts between log messages. Defaults to 60. | |
| log_every_n_attempts: Number of attempts between log messages. Defaults to 60. i.e. with poll_interval set to 10, and log_every_n_attempts set to 60, we will log ever 600 seconds which is every 10 minutes. |
10 minutes isnt too much? Usually I consider something hanging if no logs for more than 2 -4 mins.
Collaborator
Author
There was a problem hiding this comment.
We log updates every 10 minutes, I think every compute rank (e.g. num gpus) dumping every minute is probably too frequent and kind of clogs up the logs.
I guess we can make it 5 minutes? And update the logs here to expect the next update.
Collaborator
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Since dataset building is O(minutes) we might as well bump the log interval time to reduce log spam.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO