[Feature] Add configurable arguments for rollout manager actor#1596
Open
TSunny007 wants to merge 1 commit intoTHUDM:mainfrom
Open
[Feature] Add configurable arguments for rollout manager actor#1596TSunny007 wants to merge 1 commit intoTHUDM:mainfrom
TSunny007 wants to merge 1 commit intoTHUDM:mainfrom
Conversation
TSunny007
force-pushed
the
tsunkar/rollout_resources
branch
from
e337f86 to
cf67e10
Compare
Contributor
Author
|
@zhuzilin what do you think about this refactor? I'm observing that SFT can be bottlenecked because of the default resources allocated for the rollout manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to configure the resources for RolloutManager if necessary.
The default
num_cpus=1is too restrictive in some use cases and it'd be beneficial to be able to override these parameters if necessary. According to ray docs, sendingNonevalues to the other parameters will be equivalent to the defaults ray chooses.