Draft
Conversation
-use correct property names for users.createdAt and users.updatedAt -add migration for missing projects.updated_at and todos.updated_at columns -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fix the React projects example, which is currently broken.
-use correct property names for users.createdAt and users.updatedAt
-add migration for missing projects.updated_at and todos.updated_at columns -
✅ Checklist
pnpm test.Running pnpm test locally gives two errors, both in main and for this PR:
FAIL @tanstack/db-ivm tests/operators/topK.test.ts > Operators > TopK operation > incremental update - complex scenario with multiple changes
FAIL @tanstack/db-ivm tests/operators/topKWithIndex.test.ts > Operators > TopKWithIndex operation > incremental update with offset - items moving in and out of window
🚀 Release Impact
Flagging this as draft due to the pnpm test errors I observe. I don't see how fixing a broken example project could influence the tests, so I assume it's something environment related.