fix(learn): prevent errexit on '((completed++))'#601
Merged
Chemaclass merged 1 commit intoTypedDevs:mainfrom Mar 10, 2026
Merged
fix(learn): prevent errexit on '((completed++))'#601Chemaclass merged 1 commit intoTypedDevs:mainfrom
Chemaclass merged 1 commit intoTypedDevs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Run
bashunit learn, complete the first lesson, and then check your progress... 💥bashunit-learn-bug-2026-03-10_06.30.12.mp4
The problem is caused by the exit status of
((completed++)), which is non-zero if you have any lesson completed. This causeserrexit.The expected result (which I got after the fix) is to see the list of completed lessons and then back to the
bashunit learnprompt, like this:🔖 Changes
Simply added
|| true, as it seems to be the common practice in other places of the codebase.I also noticed that there isn't any test validating the
bashunit learnbehavior, then I didn't add any for such a simple fix.✅ To-do list
CHANGELOG.mdto reflect the new feature or fix