Skip to content

refactor: Changed How Response is Handled#94

Merged
usernane merged 5 commits intomainfrom
dev
Mar 5, 2026
Merged

refactor: Changed How Response is Handled#94
usernane merged 5 commits intomainfrom
dev

Conversation

@usernane
Copy link
Member

@usernane usernane commented Mar 4, 2026

Summary

Modify how response is handled by the core.

Motivation

  • Return proper response type (json, array, plain)

Changes

This pull request has following changes:
See commits.

How to test / verify

Describe testing approach, if it uses unit tests, integration or manual.

  • Unit tests

Breaking changes

  • Yes (describe + migration notes below)

Migration notes (required if breaking)

What do users need to change in thier code?
Prevusly, when a scalare/string is returned by the controller, it will return a json as response and returned value is in "message" property. Now, the value is returned as is. No Json.

Checklist

  • My commits follow Conventional Commits
  • The title of the pull request follow Conventional Commits
  • I added/updated tests (or explained why not)
  • I updated docs (if needed)
  • I ran lint/cs-fixer (if applicable)
  • I considered backward compatibility and security

Related issues

Not Applicable

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.30%. Comparing base (c6c8b2a) to head (baea2d5).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
WebFiori/Http/WebService.php 42.85% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #94      +/-   ##
============================================
- Coverage     92.46%   92.30%   -0.17%     
- Complexity     1264     1265       +1     
============================================
  Files            39       39              
  Lines          3027     3042      +15     
============================================
+ Hits           2799     2808       +9     
- Misses          228      234       +6     
Flag Coverage Δ
php-8.1 92.08% <42.85%> (-0.18%) ⬇️
php-8.2 92.14% <42.85%> (-0.16%) ⬇️
php-8.3 92.14% <42.85%> (-0.16%) ⬇️
php-8.4 92.14% <42.85%> (-0.16%) ⬇️
php-8.5 92.14% <42.85%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

@usernane usernane merged commit 9164496 into main Mar 5, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant