[wpe-2.46] Insert cencparser when available#1630
Open
emutavchi wants to merge 2 commits intoWebPlatformForEmbedded:wpe-2.46from
Open
[wpe-2.46] Insert cencparser when available#1630emutavchi wants to merge 2 commits intoWebPlatformForEmbedded:wpe-2.46from
emutavchi wants to merge 2 commits intoWebPlatformForEmbedded:wpe-2.46from
Conversation
cencparser is a custom parser that converts H264/H265 CENC video from AVC to byte-stream format. it is required to be inerted before decryptor on platforms that don't provide secure parsers and decoder only accepts video in byte-stream format.
…e is set This can happend if upstream element (a capsfilter) queires caps during negotiation.
Member
|
Can you please explain what the patch does and why, please? |
I am providing further details off-line. |
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Mar 10, 2026
https://bugs.webkit.org/show_bug.cgi?id=309582 Reviewed by NOBODY (OOPS!). cencparser is a custom parser that converts H264/H265 CENC video from AVC to byte-stream format. it is required to be inerted before decryptor on platforms that don't provide secure parsers and decoder only accepts video in byte-stream format. * Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: (transformCaps): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderParser.cpp: (tryInsertCencparser): (webkitMediaThunderParserChangeState): (webkit_media_thunder_parser_class_init): Original author: Eugene Mutavchi <Ievgen_Mutavchi@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1630
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Mar 11, 2026
https://bugs.webkit.org/show_bug.cgi?id=309582 Reviewed by NOBODY (OOPS!). cencparser is a custom parser that converts H264/H265 CENC video from AVC to byte-stream format. It is required to be inserted before decryptor on platforms that don't provide secure parsers and decoder only accepts video in byte-stream format. * Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: (transformCaps): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderParser.cpp: (tryInsertCencparser): (webkitMediaThunderParserChangeState): (webkit_media_thunder_parser_class_init): Original author: Eugene Mutavchi <Ievgen_Mutavchi@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1630 (createThunderParseSinkPadTemplateCaps): Deleted.
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Mar 12, 2026
https://bugs.webkit.org/show_bug.cgi?id=309582 Reviewed by NOBODY (OOPS!). cencparser is a custom parser that converts H264/H265 CENC video from AVC to byte-stream format. It is required to be inserted before decryptor on platforms that don't provide secure parsers and decoder only accepts video in byte-stream format. * Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: (transformCaps): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderParser.cpp: (tryInsertCencparser): (webkitMediaThunderParserChangeState): (webkit_media_thunder_parser_class_init): Original author: Eugene Mutavchi <Ievgen_Mutavchi@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1630 (createThunderParseSinkPadTemplateCaps): Deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms, we need to insert a custom parser element (cencparser) to convert H264/H265 video samples from AVC/AVC3 to byte-stream format. This is for platforms that don't provide secure parsers, but decoders only accept video in byte-stream format. So, the cencparser must be inserted before the decryptor to convert samples before they are moved to secure memory.
8d5967f