Open
Conversation
Replace xcodes' custom password prompt and sudo -S piping with a real sudo -v followed by normal sudo invocations. This lets sudo use the system PAM stack instead of collecting a password in xcodes before sudo authenticates again. Authenticate once up front in the install and xcode-select flows, then run the privileged commands normally. Update tests, fixtures, and docs to match the system-managed sudo prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
sudomechanism bypassessudo's normal PAM configuration and results in double-prompting with non-default PAM configurations.xcodeswill prompt formacOS User Password:first, and after entering the password,sudowill prompt again for its configured authentication method, like Touch ID when usingpam_tid.so.This change replaces the custom password flow with
sudo -vto do the authentication, followed by normalsudoinvocations. That letssudouse the system PAM configuration instead of collecting a password inxcodesbefore authenticating. This does not change the overall privilege model, and the existing explanatory log line before authentication is also kept intact.