Expand fitter error handling code#1177
Open
stephenswat wants to merge 1 commit intoacts-project:mainfrom
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
approved these changes
Nov 7, 2025
stephenswat
force-pushed
the
bug/kf_error_codes
branch
from
cc0aeb8 to
0c782e2
Compare
Member
Author
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298345 to 298338 (-0.0%) Seeding plots
Track finding performanceTotal number of found tracks went from 55967 to 55963 (-0.0%) Finding plots
Track fitting performanceFitting plots
Note This is an automated message produced on the explicit request of a human being. |
This commit updates the Kálmán fitter error handling code by explicitly marking failures in the forward and backwards fitting step. It also resolves an issue where the smoother would start from invalid track states.
stephenswat
force-pushed
the
bug/kf_error_codes
branch
from
0c782e2 to
11de53a
Compare
|
Member
Author
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298345 to 298344 (-0.0%) Seeding plots
Track finding performanceTotal number of found tracks went from 50745 to 50744 (-0.0%) Finding plots
Track fitting performanceFitting plots
Seeding to track finding relative performanceSeeding to track finding plots
Track finding to track fitting relative performanceTrack finding to track fitting plots
Note This is an automated message produced on the explicit request of a human being. |
niermann999
added a commit
that referenced
this pull request
Nov 13, 2025
Expand on the number of Kalman fit status codes and track fit outcomes to make a more fine-grained distinction between different error types in the Kalman fitter possible. Takes up the improvements in #1177. Edit: The wire chamber Kalman fitter test had to be adapted, because more error states are recognized Edit2: Also fixed the condition of is_complete for the backward fit to point one position below the first state
StewMH
pushed a commit
to StewMH/traccc
that referenced
this pull request
Nov 19, 2025
Expand on the number of Kalman fit status codes and track fit outcomes to make a more fine-grained distinction between different error types in the Kalman fitter possible. Takes up the improvements in acts-project#1177. Edit: The wire chamber Kalman fitter test had to be adapted, because more error states are recognized Edit2: Also fixed the condition of is_complete for the backward fit to point one position below the first state
krasznaa
added a commit
that referenced
this pull request
Jan 25, 2026
* Start to add alpaka magnetic field implementation * Temporary change to covfie fork * Fix formatting * Update magnetic field * Fixes for CUDA * Fix include * Fixes * Formatting * Update SYCL code, tell CI to build SYCL and CUDA when building relevant Alpaka flavours * Add CPU implementation * Fix formatting * Fixes for CPU running * Improve kalman fitter error handling (#1191) Expand on the number of Kalman fit status codes and track fit outcomes to make a more fine-grained distinction between different error types in the Kalman fitter possible. Takes up the improvements in #1177. Edit: The wire chamber Kalman fitter test had to be adapted, because more error states are recognized Edit2: Also fixed the condition of is_complete for the backward fit to point one position below the first state * Switch to default navigator for backward fit * Update to detray v0.105.1 * Improved hole count (#1109) If the navigation in the forward KF missed a surface, advance the track state iterator correctly (for example if the propagation config between CKF and KF is different or we are running truth fitting). This is only needed for navigators that are not "guided" or "direct". It also adds an option to the KF to do the full hole count, which is only possible if the propagation starts at the IP and continues through the whole detector, otherwise the first and last holes are missed and the hole count remains an underestimation. Since this will not help in increasing the fit accuracy, but eat more compute resources it will remain optional. * Read measurement dimensionality from detector This commit switched the measurement IO code to optionally get the dimensionality from the detector description rather than from the measurement input data. * Update track covariance estimation logic This commit reworks the covariance estimation logic to match that used in ACTS. It greatly increases the covariances of tracks, hopefully increasing the tracking efficiency. * Save disk space in CUDA CI job The CUDA CI jobs are currently running out of disk space. This commit builds ACTS separately, as a release build, in order to save space. * Remove Kokkos and Futhark code bases This PR is a revival of #652, removing the obsolete Kokkos and Futhark code bases. * Nade measurement sorting handle empty collections correctly. Did not bother with the host algorithm, because: - It's not actively used in any current workflow; - It works correctly without this optimization as well. * Use new covfie tag * Revert to URL, fix download * Separate CUDA utils into separate library for use in Alpaka * Moving to traccc::cuda_utils from traccc_cuda_utils * Moving to cuda_utils in CI * Move sycl utils to sycl_utils, use in alpaka * Link against sycl_utils * Use :: * Only put magnetic field utilities in own library: SYCL edition * Split out queue_wrapper for use in magfield and main SYCL library * Add get_queue to sycl_queue library * Pre-apply merge results for cmake files * Remove sycl_magfield library from linking * Add SYCL_UTILS to cmake config --------- Co-authored-by: Joana Niermann <53186085+niermann999@users.noreply.github.com> Co-authored-by: Joana Niermann <joana.niermann@cern.ch> Co-authored-by: Stephen Nicholas Swatman <stephen.nicholas.swatman@cern.ch> Co-authored-by: Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the Kálmán fitter error handling code by explicitly marking failures in the forward and backwards fitting step. It also resolves an issue where the smoother would start from invalid track states.