Remove measurement dimension hack in KF

[stephenswat]

Before #1187 was merged, we were unable to properly determine the dimensionality of measurements in the Kálmán filter. This necessitated a hack which can now be removed.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298345 (+0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50178 to 48228 (-3.9%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	8ef4b18	286038a	Delta	8ef4b18	286038a
propagate_to_next_surface	6.26 ms	6.23 ms	-0.4%	4.27	4.26
fit_forward	1.94 ms	1.78 ms	-7.8%	7.34	7.67
find_tracks	1.39 ms	1.39 ms	0.1%	1.81	1.81
ccl_kernel	823.48 μs	822.99 μs	-0.1%	1.37	1.37
fit_backward	672.76 μs	623.02 μs	-7.4%	5.49	5.75
count_doublets	618.81 μs	622.01 μs	0.5%	1.60	1.61
count_triplets	589.56 μs	589.16 μs	-0.1%	1.02	1.02
find_doublets	447.11 μs	447.66 μs	0.1%	3.08	3.08
Thrust::sort	385.51 μs	384.18 μs	-0.3%	7.36	7.35
find_triplets	171.29 μs	172.79 μs	0.9%	1.31	1.31
select_seeds	52.91 μs	53.68 μs	1.4%	1.34	1.34
populate_grid	23.36 μs	23.31 μs	-0.2%	1.22	1.22
remove_duplicates	23.75 μs	23.14 μs	-2.6%	25.91	27.12
count_grid_capacities	22.10 μs	22.10 μs	0.0%	1.22	1.22
fill_sorted_measurements	19.74 μs	19.76 μs	0.1%	1.13	1.13
update_triplet_weights	15.13 μs	15.10 μs	-0.2%	1.27	1.27
estimate_track_params	14.23 μs	14.22 μs	-0.1%	2.15	2.15
apply_interaction	13.95 μs	13.89 μs	-0.4%	6.66	6.67
fit_prelude	9.86 μs	9.03 μs	-8.4%	21.78	22.80
fill_finding_propagation_sort_keys	8.83 μs	8.78 μs	-0.5%	7.61	7.63
form_spacepoints	8.28 μs	8.25 μs	-0.4%	1.48	1.48
reduce_triplet_counts	6.29 μs	6.27 μs	-0.3%	3.08	3.08
unknown	5.04 μs	5.04 μs	-0.1%	4.28	4.28
build_tracks	4.08 μs	4.03 μs	-1.0%	14.77	15.51
fill_finding_duplicate_removal_sort_keys	1.57 μs	1.52 μs	-3.0%	37.96	39.19
fill_prefix_sum	171.96 ns	172.00 ns	0.0%	341.30	341.30
fill_fitting_sort_keys	153.23 ns	146.54 ns	-4.4%	22.08	23.08
Total	13.52 ms	13.30 ms	-1.6%	4.12	4.13

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[niermann999]

Maybe the subspace for line surfaces is not correct and these need to be set explicitly ?