Conversation
packages/components/.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| v20.19.3 | |||
There was a problem hiding this comment.
Looks like the latest of v20 is v20.19.4. It was just released yday (7/15) but might be good to be on this version since it looks like it was a security release
| "jest": "^29.7.0", | ||
| "jest-cli": "^29.7.0", | ||
| "jsdom-global": "^3.0.2", | ||
| "react": "^18.3.1", |
There was a problem hiding this comment.
Our gen-ai-designer-tools repo has React at "react": "^16.13.1", and I vaguely recall that React 18 introduces significant changes. This might not be a production issue since it's a dev dependency but the version mismatch might cause dev issues if react-comms is using any React 18 features. Do you foresee any issues?
Here are 3 options that I think we can do:
We could leave this at "react": "^16.13.1" and create later tickets to upgrade both this and gen-ai-designer-tools, have both react 16 || 18 versions that the package can work with, or upgrade to 18 here and address potential dev issues as they come up in gen-ai-designer-tools
There was a problem hiding this comment.
My plan is to upgrade gen-ai-designer-tools to 18, I already have a branch with those changes locally
There was a problem hiding this comment.
Does this need to be a ts file? Since you've converted the other files
There was a problem hiding this comment.
I actually only converted one file to a typescript test file, I think we can come back later and change this if we want to - would be a larger refactor
| /* eslint-disable no-underscore-dangle */ | ||
| import React, { useContext } from 'react'; | ||
| import { render, screen, act } from '@testing-library/react'; | ||
| // import '@testing-library/jest-dom'; |
| SetConfiguration: jest.fn(), | ||
| GetConfiguration: jest.fn() | ||
| GetConfiguration: jest.fn(), | ||
| Callbacks: {} |
There was a problem hiding this comment.
Callbacks should be inside window.Alteryx, not inside the Gui obj. This is what Im using for reference. Also, do the other properties need to be included here? Not sure how what the logic is to determine what gets included or not
There was a problem hiding this comment.
I kept getting an error about not having callbacks in Gui, I think possible Callbacks is a field in both
| @@ -0,0 +1,202 @@ | |||
| /* eslint-disable no-underscore-dangle */ | |||
There was a problem hiding this comment.
do these tests run in pipeline? or they are just executed manually?
There was a problem hiding this comment.
Just manually, but I'm going to push up a change so they run in the pipeline
|
Should probably add to the changelog |
| @@ -0,0 +1 @@ | |||
| registry=https://artifactory.alteryx.com/artifactory/api/npm/npm/ No newline at end of file | |||
|
Moving to gitlab |
4 participants
No description provided.