[feat] add volume and volumeMounts support for ddc#459
[feat] add volume and volumeMounts support for ddc#459gohalo wants to merge 1 commit intoapache:masterfrom
Conversation
|
This is a very useful feature, being able to mount empty dirs to specific locations on the POD, especially if you're running the pod without root and with the filesystem read-only, according to Kubernates best practices. @catpineapple do you have any idea when the operator will be released next? |
|
First of all, thank you for the submission; it's a great start. @Sbaia Your requirement is a very real issue, and doris-operator also intends to support this functionality. However, the implementation of this PR is relatively simple, and if users misuse it, it could cause unexpected errors. I prefer adding a switch to the CRD, or adding a new structure to describe local storage information. The operator would then recognize this configuration and build the corresponding Volumes and VolumeMounts, instead of having users directly fill in Volumes and VolumeMounts in the CRD. Of course, you can share any better ideas you have. If you agree with my ideas, you can also adjust this PR accordingly. Due to a recent change in work direction, processing PRs may be delayed. The next release is estimated to be in one or two months. |
What problem does this PR solve?
Add volume and volumeMounts support for ddc.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)