Skip to content

[feat] add volume and volumeMounts support for ddc#459

Open
gohalo wants to merge 1 commit intoapache:masterfrom
gohalo:feature_support_volumns
Open

[feat] add volume and volumeMounts support for ddc#459
gohalo wants to merge 1 commit intoapache:masterfrom
gohalo:feature_support_volumns

Conversation

@gohalo
Copy link

@gohalo gohalo commented Dec 1, 2025

What problem does this PR solve?

Add volume and volumeMounts support for ddc.

apiVersion: disaggregated.cluster.doris.com/v1
kind: DorisDisaggregatedCluster
metadata:
  name: simple-cluster
spec:
  computeGroups:
      volumeMounts:
      - mountPath: /usr/local/nagent
        name: nagent
        mountPropagation: HostToContainer
      volumes:
      - hostPath:
          path: /usr/local/nagent
          type: ""
        name: nagent

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Sbaia
Copy link

Sbaia commented Mar 5, 2026

This is a very useful feature, being able to mount empty dirs to specific locations on the POD, especially if you're running the pod without root and with the filesystem read-only, according to Kubernates best practices.

@catpineapple do you have any idea when the operator will be released next?

@catpineapple
Copy link
Contributor

First of all, thank you for the submission; it's a great start.

@Sbaia Your requirement is a very real issue, and doris-operator also intends to support this functionality. However, the implementation of this PR is relatively simple, and if users misuse it, it could cause unexpected errors.

I prefer adding a switch to the CRD, or adding a new structure to describe local storage information. The operator would then recognize this configuration and build the corresponding Volumes and VolumeMounts, instead of having users directly fill in Volumes and VolumeMounts in the CRD.

Of course, you can share any better ideas you have. If you agree with my ideas, you can also adjust this PR accordingly.

Due to a recent change in work direction, processing PRs may be delayed. The next release is estimated to be in one or two months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants