Skip to content

[helm] Fix .helmignore to not package tests#2847

Open
affo wants to merge 1 commit intoapache:mainfrom
affo:la-fix-helmignore
Open

[helm] Fix .helmignore to not package tests#2847
affo wants to merge 1 commit intoapache:mainfrom
affo:la-fix-helmignore

Conversation

@affo
Copy link
Contributor

@affo affo commented Mar 11, 2026

Purpose

Linked issue: close #xxx

No issue created.

We were inadvertently packaging Helm tests as part of the charts.

Brief change log

Add tests as part of .helmignore

Tests

Manual test:

With the change:

helm package .
Successfully packaged chart and saved it to: /Users/lorenzo/repos/fluss/helm/fluss-0.10.0-incubating.tgz
➜  helm git:(la-fix-helmignore) ✗ tar tf ./fluss-0.10.0-incubating.tgz| grep tests
# nothing

Without

git stash
Saved working directory and index state WIP on la-fix-helmignore: 2f8cadad [fluss-client] Support Complex Data Types on the Java Typed API (Map and Array) (#2814)
➜  helm git:(la-fix-helmignore) ✗ helm package .                                  
Successfully packaged chart and saved it to: /Users/lorenzo/repos/fluss/helm/fluss-0.10.0-incubating.tgz
➜  helm git:(la-fix-helmignore) ✗ tar tf ./fluss-0.10.0-incubating.tgz| grep tests
fluss/tests/imagepullsecrets_test.yaml

API and Format

Documentation

Copy link
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@affo
Copy link
Contributor Author

affo commented Mar 12, 2026

@xx789633 would you be willing to review this one?
Is there a way to re-run CI?
Probably flakey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants