Draft
Conversation
(cherry picked from commit 89fc4ca) (cherry picked from commit 9bf5c8ac6333b0d7e45e12ff537fd1a975b103e7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ComponentVersionManagerclass which tracks apparent version, software version, and finalization status using the new unified version framework based around component version.nextVersionmethod to allComponentVersionswhich points from the current version to the one immediately following it for use when finalizing.HDDSLayoutFeatureandOMLayoutFeature's last version'snextVersionimplementations point toHDDSVersion#ZDUandOzoneManagerVersion#ZDUrespectively to handle the transition from layout feature to component version during finalization.ComponentVersionManagerimplementation will work whether or not we are finalized for ZDU, because it can depend on thenextVersioncall to transparently make the switch when finalizing.A follow-up change will switch the current upgrade path from using
AbstractLayoutVersionManagerand its subclasses to the newComponentVersionManager.What is the link to the Apache JIRA
HDDS-14732
How was this patch tested?
Leaving as draft until unit tests for the changes are added.
Existing tests should be unaffected since the existing layout version managers are still connected to the main upgrade path.