Skip to content

HDDS-14808. [STS] Part 4 - IAM Session Policy and ListBucket improvements#9899

Draft
fmorg-git wants to merge 4 commits intoapache:HDDS-13323-stsfrom
fmorg-git:HDDS-14808
Draft

HDDS-14808. [STS] Part 4 - IAM Session Policy and ListBucket improvements#9899
fmorg-git wants to merge 4 commits intoapache:HDDS-13323-stsfrom
fmorg-git:HDDS-14808

Conversation

@fmorg-git
Copy link
Contributor

Please describe your PR in detail:
We need to be able to tell whether an S3 STS call is authorized for listing files in a bucket only vs being able to download a file, because those are different actions in S3 (ListBucket vs GetObject). To differentiate, use LIST at key/object level for listing permission and use READ at key/object level for downloading permission. Currently, the OmMetadataReader authorizes only READ at key level for the listing operations. In order to not break existing functionality, have STS-specific checks that authorize against LIST permission instead. Further, because of how shallow listing works, in some cases (ex. root listing with a delimiter), it loses the context of what the original prefix was on the S3 request. For STS authorization, we need this original prefix, so introduce an optional listPrefix in the protocol to support this.



Here are a quick summary of the total requisite changes:

  1. Support passing list prefix on root listing so STS can authorize against it.
  2. Filter out non-ListBucket actions (ex GetObject, PutObject, ListBucketMultipartUploads, etc) when Conditions are present since we only support s3:prefix Condition and s3:prefix is only applicable for ListBucket and ListBucketVersions (we don't support this).
  3. Keep track of the operator (i.e. StringEquals or StringLike) when using Conditions. If the operator is StringEquals and a wildcard (* or ?) is used, ignore that condition since Ranger can’t authorize against literal asterisk or question mark.
  4. Change ListBucket to validate LIST permission on the object instead of READ so we can determine if we should allow listing the object or downloading the object (READ would be for downloading).

This part 4 PR is to keep track of the operator in Conditions so that if the operator is StringEquals and a wildcard is used, the condition is ignored.
This PR depends on #9896.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14808

How was this patch tested?

unit tests, smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant