Open
Conversation
Philippus
force-pushed
the
update-http-compatibility-tests
branch
from
9d2a8bd to
543833e
Compare
Philippus
force-pushed
the
update-http-compatibility-tests
branch
from
543833e to
7d91048
Compare
Philippus
force-pushed
the
update-http-compatibility-tests
branch
from
7d91048 to
9547e20
Compare
jrudolph
approved these changes
Mar 23, 2026
Contributor
jrudolph
left a comment
jrudolph
left a comment
There was a problem hiding this comment.
LGTM
The question is whether these tests are even necessary right now?They were added for quite a specific change a long time ago. If we don't update them with new tests, it might not even make sense to keep any of them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports part of akka/akka-http#4181.
Part of #960.
Relates to #355.