Skip to content

Add null check for getgrgid() in eigerDetector::writeOctet, fixes #85#86

Merged
MarkRivers merged 2 commits intoareaDetector:masterfrom
nmarks99:master
Mar 4, 2026
Merged

Add null check for getgrgid() in eigerDetector::writeOctet, fixes #85#86
MarkRivers merged 2 commits intoareaDetector:masterfrom
nmarks99:master

Conversation

@nmarks99
Copy link
Contributor

@nmarks99 nmarks99 commented Feb 8, 2026

This fixes #85. Perhaps a similar check should also be done for getpwuid as well?

mFileOwner->put(getpwuid(mFsUid)->pw_name);

Copy link
Member

@MarkRivers MarkRivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here looks fine but there appears to be whitespace issue. Did you use tab characters? Line 731 is not indented and lines 733 and 734 appear to have too much indent.

@nmarks99
Copy link
Contributor Author

nmarks99 commented Mar 4, 2026

Ah yes sorry about that, it was using tab characters. I think it is fixed now

@MarkRivers MarkRivers merged commit e878f09 into areaDetector:master Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null pointer dereference in eigerDetector::writeOctet if name for user's GID is missing

2 participants