Open
Conversation
JonathanOppenheimer
changed the title
debug_getRaw* RPCs
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
Contributor
StephenButtolph
left a comment
StephenButtolph
left a comment
There was a problem hiding this comment.
Related comment from a prior PR: #154 (comment)
Member
Author
Addressed. |
alarso16
approved these changes
Mar 10, 2026
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
Seems ok, more test coverage can't be bad
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/test-debug-raw-rpcs
branch
from
4dda5c0 to
33aa6fa
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/test-debug-raw-rpcs
branch
from
33aa6fa to
7260f32
Compare
Member
Author
|
Note that #280 did introduce another behavior change -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the remaining
debug_getRaw*RPC methods, now thatBlockByNumberOrHashandGetReceiptshave been implemented. I also added coverage fordebug_printBlockas it seems this was mistakenly added to the list without being tested.