Skip to content

fix: remove duplicate blob_fields call in build_block#952

Merged
refcell merged 1 commit intobase:mainfrom
eeemmmmmm:fix/remove-duplicate-blob-fields-call
Mar 2, 2026
Merged

fix: remove duplicate blob_fields call in build_block#952
refcell merged 1 commit intobase:mainfrom
eeemmmmmm:fix/remove-duplicate-blob-fields-call

Conversation

@eeemmmmmm
Copy link
Contributor

Remove redundant second call to ctx.blob_fields(info) in build_block function. The blob_gas_used value was already computed on line 970 and reused correctly on line 1101, making the second call an unnecessary operation.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 2, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@Ziqi52
Copy link

Ziqi52 commented Mar 2, 2026

Remove redundant second call to ctx.blob_fields(info) in build_block function. The blob_gas_used value was already computed on line 970 and reused correctly on line 1101, making the second call an unnecessary operation.

wow

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. The blob gas used is computed using the execution info which isn't changed between these two computations, so the re-computation was just shadowing the previous earlier computation. Wish the original author left a comment to explain why this was done, but looks to be a no-op.

@refcell refcell enabled auto-merge March 2, 2026 13:57
@refcell refcell added this pull request to the merge queue Mar 2, 2026
Merged via the queue into base:main with commit 42f1ca9 Mar 2, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants