Skip to content

Update react-vega to v8 and adapt VegaChart accordingly#141

Open
clarasb wants to merge 10 commits intomainfrom
clarasb-132-update_VegaChart
Open

Update react-vega to v8 and adapt VegaChart accordingly#141
clarasb wants to merge 10 commits intomainfrom
clarasb-132-update_VegaChart

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Mar 3, 2026

This PR:

  • updates react-vega to v8 and adapts VegaChart accordingly (see rect-vega migration guide)
  • removes altair pinning. This is not necessary anymore
  • integrates VegaChart component in testing (after beeing excluded in Update vega #131)

Closes #132.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (e295ef8) to head (ad8def6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   92.28%   92.91%   +0.63%     
==========================================
  Files          89       90       +1     
  Lines        1529     1553      +24     
  Branches      235      236       +1     
==========================================
+ Hits         1411     1443      +32     
+ Misses         99       92       -7     
+ Partials       19       18       -1     
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend 85.52% <100.00%> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clarasb clarasb marked this pull request as ready for review March 4, 2026 11:18
@clarasb clarasb requested review from b-yogesh and forman March 4, 2026 11:19
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Clara, it LGTM! Did you also test this out in a fresh node environment and the demos work as expected?

@clarasb clarasb requested a review from forman March 9, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update VegaCharts component

3 participants