Skip to content

factored the optional_sender into a header shared by multiple tests#233

Open
dietmarkuehl wants to merge 3 commits intomainfrom
factor-out-optional_sender
Open

factored the optional_sender into a header shared by multiple tests#233
dietmarkuehl wants to merge 3 commits intomainfrom
factor-out-optional_sender

Conversation

@dietmarkuehl
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 23:24
@dietmarkuehl dietmarkuehl requested a review from camio as a code owner March 3, 2026 23:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR factors a locally-defined optional_sender test helper out of individual tests into a shared header so multiple tests can reuse the same sender implementation.

Changes:

  • Added a shared test helper header: test/optional_sender.hpp.
  • Updated exec-stopped-as-optional and exec-stopped-as-error tests to include and use test::optional_sender.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
tests/beman/execution/include/test/optional_sender.hpp Introduces shared optional_sender sender type for reuse across tests.
tests/beman/execution/exec-stopped-as-optional.test.cpp Replaces local helper with the shared test::optional_sender header.
tests/beman/execution/exec-stopped-as-error.test.cpp Replaces local helper with the shared test::optional_sender header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Mar 3, 2026

Coverage Status

coverage: 95.238%. remained the same
when pulling 507b19e on factor-out-optional_sender
into 82f2c42 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants