fix: add error messages for empty or failed exports (fixes #15)#17
Open
anjalichhikara-0907 wants to merge 1 commit intocdli-gh:masterfrom
Open
fix: add error messages for empty or failed exports (fixes #15)#17anjalichhikara-0907 wants to merge 1 commit intocdli-gh:masterfrom
anjalichhikara-0907 wants to merge 1 commit intocdli-gh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
cdli export --format atf --entities artifacts, the exportsilently returns an empty file with no feedback to the user. This is
confusing as users don't know if the command failed or succeeded.
Changes
process.stderr.writedirectly forbetter visibility
causes
or 'ntriples' when atf export fails
Testing
Run the following to reproduce the original issue and verify the fix:
cdli export --host https://cdli.earth/ --entities artifacts --format atfBefore fix: silent empty download
After fix: clear error message with guidance on correct formats
Related
Fixes #15